0Day Forums
Spring-Data JPA CrudRepository returns Iterable, is it OK to cast this to List? - Printable Version

+- 0Day Forums (https://0day.red)
+-- Forum: Coding (https://0day.red/Forum-Coding)
+--- Forum: FrameWork (https://0day.red/Forum-FrameWork)
+---- Forum: Spring (https://0day.red/Forum-Spring)
+---- Thread: Spring-Data JPA CrudRepository returns Iterable, is it OK to cast this to List? (/Thread-Spring-Data-JPA-CrudRepository-returns-Iterable-is-it-OK-to-cast-this-to-List)



Spring-Data JPA CrudRepository returns Iterable, is it OK to cast this to List? - cotangent578819 - 08-02-2023

I'm writing a code-gen tool to generate backend wiring code for Spring Boot applications using Spring Data JPA and it's mildly annoying me that the methods in the `CrudRepository` return `Iterable` rather than `List`, as `Iterable` doesn't provide quite enough functionality, but `List` does, so I'm looking for the best way to convert the `Iterable` into a `List`.

I saw [this post](

[To see links please register here]

) on changing an `Iterable` to a `Collection` and I was wondering, rather than using a library like Guava or implementing my own function to do the conversion, why not just cast it to `List`? Is there something wrong with doing that that I don't know about?

**Edit**:
I ask because since it's a code-gen tool it's not reasonable to make it generate code that introduces dependencies on 3rd party libraries, and writing my own function to do the conversion also isn't really reasonable because it would have to live somewhere and I'd rather not have that in the generated code. A simple cast will work, if a little ugly, but just wondered if there's something I'm missing?